flake8: fix E714 test for object identity should be 'is not'

autopep8: fix E225 missing whitespace around operator

flake8: fix E713 test for membership should be 'not in'

autopep8: fix E262 inline comment should start with '# '

autopep8: fix E129 visually indented line with same indent as next logical line

autopep8: fix E128 continuation line under-indented for visual indent

flake8: fix E722 do not use bare 'except'

autopep8: fix E227 missing whitespace around bitwise or shift operator

autopep8: fix E225 missing whitespace around operator

autopep8: fix E221 multiple spaces before operator

autopep8: fix E231 missing whitespace after ','

autopep8: fix E301/E302 expected 1/2 blank line, found 0/1

autopep8: fix E306 expected 1 blank line before a nested definition, found 0

autopep8: fix E401 multiple imports on one line

autopep8: fix E702 multiple statements on one line (semicolon)

autopep8: fix W391 blank line at end of file

autopep8: fix W291 trailing whitespace

autopep8: fix E125 continuation line with same indent as next logical line

autopep8: fix E124 closing bracket does not match visual indentation

Drop commented code causing of flake8 errors

autopep8: fix E111 indentation is not a multiple of four

autopep8: fix E202 whitespace before ')'

autopep8: fix E303 too many blank lines

autopep8: fix E127 continuation line over-indented for visual indent

autopep8: fix E305 expected 2 blank lines after class or function definition

Configure flake8 to allo 100-long lines

Added tag 0.35.1 for changeset 01b2152b778a

[pkg] Version 0.35.1

Add a "should_register_op" class attribute to ScopeNode This a follow-up on changeset a0bf7565501f which introduce usage of this attribute in set_having() method. Sometimes, derived would classes implement this method (e.g. through EditableMixIn or directly, like Union) but some statement would not (e.g. Delete). So this breaks any mutable query using an HAVING clause. For instance, in cubicweb: self = <unittest_querier.QuerierTC testMethod=test_update_having> def test_update_having(self): peid1 = self.qexecute("INSERT Personne Y: Y nom 'hop', Y tel 1")[0][0] peid2 = self.qexecute("INSERT Personne Y: Y nom 'hop', Y tel 2")[0][0] > rset = self.qexecute("SET X tel 3 WHERE X tel TEL HAVING TEL&1=1") cubicweb/server/test/unittest_querier.py:1354: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ cubicweb/devtools/repotest.py:193: in qexecute return self.o.execute(cnx, rql, args, build_descr) cubicweb/server/sqlutils.py:488: in new_execute rset = base_execute(*args, **kwargs) cubicweb/statsd_logger.py:135: in __call__ return self.callable(*args, **kw) cubicweb/server/querier.py:532: in execute rqlst, cachekey = self.rql_cache.get(cnx, rql, args) cubicweb/server/querier.py:659: in get rqlst = self._parse(rql) cubicweb/server/querier.py:629: in parse return parse(text_type(rql), annotate=annotate) .tox/py27-server/local/lib/python2.7/site-packages/rql/__init__.py:91: in parse rqlst = parse(rqlstring, False) .tox/py27-server/local/lib/python2.7/site-packages/rql/__init__.py:213: in parse return parser.goal() .tox/py27-server/local/lib/python2.7/site-packages/rql/parser.py:123: in goal update = self.update(Set(), _context) .tox/py27-server/local/lib/python2.7/site-packages/rql/parser.py:167: in update having = self.having(R, _context) .tox/py27-server/local/lib/python2.7/site-packages/rql/parser.py:243: in having S.set_having([logical_expr]) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = SET Relation(VarRef(X) tel = 3) WHERE Relation(VarRef(X) tel = VarRef(TEL)) terms = [= (VarRef(TEL) & 1), 1] def set_having(self, terms): > if self.should_register_op: E AttributeError: 'Set' object has no attribute 'should_register_op' .tox/py27-server/local/lib/python2.7/site-packages/rql/stmts.py:82: AttributeError So, we simply add a class attribute with a None value so that the interface of this ScopeNode class is at least self-consistent. Adding a non-regression test with a DELETE and a SET queries. (Note that most existing non-regression tests do not contain assertions, they just call functions in the hope they do not crash; the new test just follows this pattern as I don't know what to check.)

[readme] fix custom spelling

Added tag 0.35.0, centos/0.35.0-1, debian/0.35.0-1 for changeset 148f94dda768

[pkg] version 0.35.0

add script to build manylinux wheels in docker

[gecode] make the extension compatible with libgecode6 cf. http://www.gecode.org/doc-latest/reference/PageHowToChange__6.html

beautify C++ code with clang-format This removes tabs and spaces mix and make the readable again

upgrade to gecode5.x API http://www.gecode.org/doc-latest/reference/PageHowToChange__5.html says that brancher handlers have been removed and that `BrancherGroup` should be used instead. use the `BrancherGroup:all` static member to get the special brancher group that gathers all branchers in a space, and fetch the number of branchers it contains. cf. http://www.gecode.org/doc-latest/MPG.pdf Do the same thing for propagators.

[tox] Use py3 environment instead of py34 The former would select any Python 3 interpreter.

Add "undo" support for HAVING clause Closes #10058776.

Added tag 0.34.2, debian/0.34.2-1, centos/0.34.2-1 for changeset 0736f99993c4

Prepare 0.34.2

[test] cleanup a bit

Start test using py.test This includes turning generative test into subtest, using standard api for doctest and some use of bare unittest instead of lgc.testlib as bonus.

[pkg] Add python-logilab-constraint to debian dependencies else we may run into problem when pkg_resources is used, as it will detect that a dependancy in the python package isn't installed. Fix it this way rather than using extras_require because we want the package to be usable with a simple pip install. Closes #9343431

Do not set uidrel if RHS of the relation is not a constant. Closes #9441457

make add_type_restriction accept a list of entity types closes #10041087

Added tag 0.34.1, debian/0.34.1-1, centos/0.34.1-1 for changeset a28961595870

[pkg] Version 0.34.1

[tox] Use `python -m` to run lgc.pytest Since the binary will disappear in logilab-common 1.3.0.

[parsing] Raise BadRQLQuery if shortcut type settings is used without any variable Before this 'Machin 12' is transformed to 'Any 12' since it expect a 'set type shortcut', but since the selection doesn't hold any variable, the type information is lost and no type checking is ever done. We can not expect to have the schema at this point, which would allow to check if the type exists. Even if we had, we would then need dedicated structures to hold the information that we expect entity with eid '12' to be a 'Machin'... Thus, it seems simpler to disallow usage of this simplified form without any selected variable. Closes #9234282.

[nodes] kill unused import

[__pkginfo__] use yapp2 in requires.txt since that is the one being installed by debian package (and also fits in pip install scenario)

Added tag centos/0.34.0-3 for changeset 896214a33f89

[pkg] fix files listing in spec

Added tag centos/0.34.0-2 for changeset a9be3f7161c4

[pkg] do not include all files in spec our spec files conflict with filesystem package in centos7: we set permission 755 for /usr/bin and /usr/lib whereas filesystem set it to 555. So to be compatible with both centos7 and others we simply ignore theses directories.

Added tag 0.34.0, centos/0.34.0-1, debian/0.34.0-1 for changeset 8411efb08f71

[pkg] don't try to build the python3 package if the python3 version is too old

[pkg] add missing build-dependencies, and don't try to run tests pybuild doesn't seem to find any tests. We should fix that, but, later.

Use python3-compatible syntax in parser_main

[pkg] 0.34.0

Fix crash introduced by previous cset 7b01294f336d when types are actually yams schema instead of bare string, one ended up with: File "/usr/lib/python2.7/dist-packages/rql/nodes.py", line 639, in get_type if lhstype == rhstype and not 'Date' in lhstype: TypeError: argument of type 'CubicWebEntitySchema' is not iterable

test and fix implementation of get_type for date arithmetic * add support for TZDatetime * properly raise on unsupported addition (e.g. date+date) * dates can be added to Interval, not Time Closes #3248236

yapps sends errors to stderr not stdout Capturing the latter only results in an empty StringIO.

[pkg] add pypi classifiers

[pkg] Declare API breaks in packaging

add tox config

[tests] Add tests to exercise various code paths in Select.replace() The original patch for bug #1190458 broke tests in CubicWeb. The patch has now been amended to fix the broken paths (namely, replacing the 'in' tests with appropriate 'is_equivalent' loops). These tests are adapted from CubicWeb's own test suite, especially those that test FTIRANK() on sqlite (the function exists but is replaced by a no-op).

[py3k] dict.itervalues → dict.values

[debian] build python3 package Related to #1167312

[py3k] more print_function Mostly in comments and defunct tools. Related to #1167312

[py3k] Unicode everywhere, drop as_string()'s 'encoding' parameter WARNING: This is an API break Among other things we no longer use repr() for String constants, which means they consistently get quoted with double quotes instead of a mix of single and double quotes. Closes #1190507

[py3k] work with str (and not bytes) in python 3 Related to #1167312

gecode_solver: fix build for python3 - there is no distinction between PyInt and PyLong anymore - module initialization changed a bit Related to #1167312

[nodes] Drop VariableRef.__cmp__ implementation (closes #1190458) The existing implementation relies on hash returning different values for objects that compared equal. This is horribly wrong. Instead, stop implementing comparison, and use the is_equivalent method explicitly.

Added tag 0.33.2, debian/0.33.2-1, centos/0.33.2-1 for changeset c629ea9f78f6

[pkg] 0.33.2

[pkg] don't crash if g++ is not in $PATH Closes #298337

Added tag debian/0.33.1-2 for changeset d5be0ab6712c

[pkg] fix Debian package dependencies Fix regression introduced by switch to dh_python2: it reads our egg-info/requires.txt to try and guess package dependencies. This generates a broken dependency on nonexistent "python-yapps" (instead of yapps2-runtime) and an unnecessary one on python-logilab-constraint (we use gecode).

Added tag 0.33.1, debian/0.33.1-1, centos/0.33.1-1 for changeset 0906f9daa48e

[pkg] add missing setuptools dependency to spec file

[pkg] Fix debian clean rule

Update ChangeLog

update MANIFEST for layout change

[pkg] Update debian packaging

[pkg] adjust makefile for changed paths

[pkg] restore conditional compilation of C extension

[rqlhelper] use threading.Lock as context manager

[pkg] make pkginfo's gecode version check a bit less ugly Use subprocess instead of os.system.

[pkg] Use setuptools Move sources to a 'rql' subdirectory, drop the NO_SETUPTOOLS code path (essentially rewriting all of setup.py). This avoids a conflict between our parser.py and the stdlib when running setup.py. Closes #278637.

[py3k] fix relative import Implicit relative imports no longer work.

pkginfo: adjust for python3 Popen's stdout is a byte stream.

[pkg] 0.33.1

[py3k] dicts are no longer comparable Instead of sorting and comparing lists of dicts, use assertCountEqual.

[py3k] iterator.__next__()

[py3k] next(iterator) instead of iterator.next() Requires python >= 2.6.

[py3k] Replace hand-coded 'basestring' with six.string_types

[py3k] Import zip from six.moves

[py3k] dict.keys/values/items() are now iterators/memoryviews

[py3k] dict.iter*() no longer exist

[py3k] 'long' and 'unicode' are no longer available Use six-provided "types" whenever possible.

[py3k] print function Requires python >= 2.6.

[py3k] except as Requires python >= 2.6.

[py3k] Import range from six.moves

[py3k] Import StringIO from six

[pkg] Add dependency on six

[py3k] Fix raise with embedded traceback python 3 removed the raise syntax with 3 expressions.

[test] replace deprecated TestCase.assert_

[analyze] remove unused imports

[test] drop __future__.with_statement import We no longer support python 2.5.

[debian] python 2.5 is no longer supported

[stcheck] don't import 'any' from lgc.compat All supported python versions have it builtin.

Added tag rql-version-0.33.0, rql-debian-version-0.33.0-1, rql-centos-version-0.33.0-1 for changeset 659a6b26eedc

[pkg] 0.33.0

[stcheck] fix visit_constant checker: a etype inside a CAST is a good thing Actually, if you put a CAST after a relation (!= ``is`` or ``is_instance_of``), the checker raises an error saying that the etype (inside the CAST) must be after a ``is`` or ``is_instance_of`` relation. In fact the CAST case was tested too late. This allow to use CAST outside the selection section, so: Closes #79232

[pkg] remove lenny and hardy packaging material

Added tag rql-version-0.32.0, rql-debian-version-0.32.0-1, rql-centos-version-0.32.0-1 for changeset 843843e76fac

[pkg] prepare 0.32.0

Allow rql to work with yapps 2.2.0 which is properly released on pypi, and remove the custom dependency link for it. Closes #124962 Closes #245540

[stcheck] remove overzealous check (closes #240176) Allow multiple (non "=") operators for uid variables.

Add missing comma in utils.KEYWORDS (closes #245563)

backport stable

Added tag rql-debian-version-0.31.5-1 for changeset 2fd17ed747d8

Added tag rql-version-0.31.5 for changeset 816abac7f9ad

0.31.5

add pygments lexer to colorize query strings (closes #34252)

[nodes] remove id(obj) in reprs It just degrades the readability for no apparent benefit. Closes #190394.

use set_optional so one will get properly warned if erroneous value is given

add_type_restriction properly behave vs is_instance_of relation. Closes #176472

[test] extend a bit add_type_restriction tests

properly undoable stmt.add_type_restriction. Closes #176469

merge changes from stable

Added tag rql-centos-version-0.31.4-1, rql-version-0.31.4, rql-debian-version-0.31.4-1 for changeset 5cad47e1ffbf

[gecode] fix build against gecode 4.2.0 (closes #167329) memory statistics have been removed from the search engines.

remove has_key usage

Add EXISTS, ILIKE, DISTINCT to KEYWORDS (closes #165898)

[pkg] Add an env var to force building the binary extension And use it in the Debian packaging to make sure we don't end up with a disfunctional package. Closes #159003

[debian] don't use sub-shells, and don't ignore errors from loops Related to #159003

Fix build against gecode 4.0.0 Looks like they changed enums to functions. Closes #159002

prepare 0.31.4

[pkg] Make sure the gecode extension build never ever fails (closes #158948) In some cases (eg, windows without Visual Studio installed), distutils/setuptools build_ext.run() may raise exceptions other than CompileError. By catching all exceptions, we can make sure rql's setup.py never fails, which should help dumb package managers such as pip.

fix add_type_restriction() implementation with IN() function (closes #138635) When the variable type is defined by an IN() function, ``add_type_restriction`` removes all types in it that don't match the specified type. Since the list of types is modified inplace, the iteration must be done on a copy, not on the list itself. There was a test for "add_type_restriction + IN()" case but since there was only 2 types defined in the IN function, the problem was not exposed.

backport stable

Added tag rql-centos-version-0.31.3-1 for changeset 496945a4ed23

[packaging] fix spec file (remove erroneous BuildArch) and bump version number

default is stable

[packaging] spec file tweaks make it look more like our other modules

Added tag rql-debian-version-0.31.3-1 for changeset f388ee9b713d

Added tag rql-version-0.31.3 for changeset 2ce80cbd45f7

prepare 0.31.3

[pkginfo] fix logilab-constraint reference (closes #115820)

[packaging] add spec file

[merge] backport stable

doc: adjust layout.html template for compatibility with sphinx 0.6 sphinx 0.6 switched templates to jinja2, which has an incompatible syntax for macros. 2009, here we come! Closes #113086.

[pkg] url changed for yapps

docstring fix

Added tag rql-debian-version-0.31.2-1 for changeset 513a02cce3c2

Added tag rql-version-0.31.2 for changeset 55af3a14cc29

0.31.2

move valuable_references from Variable to Referencable, it makes sense for ColumnAliases as well

analyse: add an env var to force using logilab constraint for resolution This is very useful for test

[debian] spread dependency declaration on multiple line. This is much more readable

pkg: bump constraint depency version We need this for set comparison implemented in 2a175b352c78

cleanup accept and leave method on various visitable object (closes #89659) The old code did: * forge a string * eval it as a lamba * monkey patch classes with the result We may just drop the logic looping on multiple class by computing class name dynamically. But this have a different behavior for subclass.

Refactor an if: else: clause as elif

drop unittest2 deprecation warnings

[analyse] speed up Query analysis for solutions (closes #88559) Use set instead of list for domains. This remove some N² complexity. Simplify the visite_relation code to: * avoid computation duplication, * compare string instead of Yams object, * take advantage of set.

Added tag rql-debian-version-0.31.1-1 for changeset 543fe6d74b49

Added tag rql-version-0.31.1 for changeset 6135951b6c7e

close changelog

0.31.1

fix simplify for rql w/ subqueries, bad local variable overwrite. Closes #87988

stable is 0.31

oldstable is 0.30

Added tag rql-debian-version-0.31.0-1 for changeset f4f27e4c588e

Added tag rql-version-0.31.0 for changeset bb70a998ced6

0.31

[node] fix add_type_restriction (closes #81817)

fix Referencable.get_type crash when no solution given and 'is IN(ET1, ET2..) is used. Closes #81865

fix wrong type analysis with 'NOT identity' (closes #80799)

update changelog

668:b2e231cbd9da introduces unrelated changes that 1. break tests, 2. make rql>0.30.1 incompatible with cw < 3.13.10

[rql] HAVING support in write queries (INSERT,SET,DELETE). Closes #81394

backport stable

closes #78681: stcheck don't crash on column aliases used in outer join

default is stable

Added tag rql-debian-version-0.30.1-1 for changeset 13cd741f8e14

Added tag rql-version-0.30.1 for changeset 3c17b96750ad

0.30.1

closes #74727: allow entity types to end with a capitalized letter provided they contain a lower-cased letter

backport stable

Added tag rql-debian-version-0.30.0-1 for changeset c3ae2279fe70

Added tag rql-version-0.30.0 for changeset 395b876af47b

0.30

drop old bw compat for ORDERBY/GROUPBY after WHERE

closes #69185: syntax error with unary operators

closes #72052: new optional 'optcomparisons' key in variable stinfo containing HAVING comparison nodes where it's used and optional (eg outer join)

closes #72295: add some missing operators * & (bitwise AND), * | (bitwise OR), * # (bitwise XOR), * << (bitwise left shift), * >> (bitwise right shift) * % (modulo), * ^ (power),

fix Comparison.as_string to considerer its optional attribute

backport stable